fix: lazily run npm install when applying 'prettier' and client modules #11113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a package-lock.json is detected, and npm command is present, run npm install. Fixes jhipster#11106
|
Let me having a look on this solution |
| NpmInstallationType npmInstallationType = npmInstallationReader.get(); | ||
| switch (npmInstallationType) { | ||
| case UNIX: | ||
| execute(folder, "npm", "install"); |
There was a problem hiding this comment.
maybe it should be ci instead of install ?
| execute(folder, "npm", "install"); | ||
| break; | ||
| case WINDOWS: | ||
| execute(folder, "npm.cmd", "install"); |
There was a problem hiding this comment.
maybe it should be ci instead of install ?
| Assert.notNull("folder", folder); | ||
|
|
||
| if (!folder.fileExists("package-lock.json")) { | ||
| log.info("No package-lock.json found, npm install skipped"); |
There was a problem hiding this comment.
Suggested change
| log.info("No package-lock.json found, npm install skipped"); | |
| log.info("No package-lock.json found, npm ci skipped"); |
| execute(folder, "npm.cmd", "install"); | ||
| break; | ||
| case NONE: | ||
| log.info("No npm installed, can't install project"); |
There was a problem hiding this comment.
Suggested change
| log.info("No npm installed, can't install project"); | |
| log.info("No npm installed, can't launch npm ci"); |
| Process process = new ProcessBuilder(commands).directory(folderFile(path)).start(); | ||
|
|
||
| if (failedExecution(process)) { | ||
| throw new NpmInstallException("Error during formatting, process failed"); |
There was a problem hiding this comment.
it could be used for another command, so it should not be related to formatting
|
|
||
| traceProcess(String.join(" ", commands), process); | ||
| } catch (IOException e) { | ||
| throw new NpmInstallException("Error during formatting: " + e.getMessage(), e); |
There was a problem hiding this comment.
it could be used for another command, so it should not be related to formatting
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
|
|
||
| throw new NpmInstallException("Error during formatting: " + e.getMessage(), e); |
There was a problem hiding this comment.
it could be used for another command, so it should not be related to formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a package-lock.json is detected, and npm command is present, run npm install.
Fixes #11106
If we agree on the solution, we should do the same with any module that touches prettier or eslint configuration: