267 use async await #275
267 use async await #275
Conversation
replace deasync by async await
|
I know it's deprecated. But someone like use, us it. So you can merge it to simplify the usage. |
267 use async await
| @@ -33,7 +33,7 @@ module.exports = { | |||
| * @param root {Object} the document's root. | |||
| * @return {string} the editor's name. | |||
| */ | |||
| function detect(root) { | |||
| async function detect(root) { | |||
There was a problem hiding this comment.
perhaps it would be better to refactor this to remove the path where we ask the user to choose the editor.
There was a problem hiding this comment.
I get back to this, I don't see what you want. I think we must split in different Merge request
| "inquirer": "6.3.1", | ||
| "jhipster-core": "3.6.14", | ||
| "jhipster-core": "3.6.6", |
There was a problem hiding this comment.
Because even if it’s a minor version api change. The values function. Has been removed. Other way. I copy it and use last dep
There was a problem hiding this comment.
I don't get it, what has changed exactly?
There was a problem hiding this comment.
There was a problem hiding this comment.
function named "values" has been removed
There was a problem hiding this comment.
Ah, just replace ObjectUtils.values by Object.values
There was a problem hiding this comment.
it's not ok what i have done?
Dufgui
force-pushed
the
267_use_async_await
branch
2 times, most recently
from
8ca089f
to
6e0ffb8
Compare
|
I don't see any point in merging PRs here, the project is deprecated for a reason, so that we don't spend any time on on it. @Dufgui why don't you fork it make the changes you want and use it |
Dufgui
force-pushed
the
267_use_async_await
branch
from
a4b52ed
to
1ea55ec
Compare
Dufgui
force-pushed
the
267_use_async_await
branch
from
1ea55ec
to
433f78d
Compare
Please make sure the below checklist is followed for Pull Requests.