Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IntelliJ config #623

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Fix IntelliJ config #623

merged 1 commit into from
Nov 26, 2023

Conversation

koppor
Copy link
Contributor

@koppor koppor commented Nov 17, 2023 •
edited
Loading

What changed with this PR:

The current IntelliJ screenshot does not match the import configuration.

  • GJF does not allow wildcard imports
  • GJF just distinguishes between static and non-static. Nothing more.

See

prettier-java/docs/checkstyle/checkstyle.xml

Line 78 in b56e69f

<property name="customImportOrderRules" value="STATIC###THIRD_PARTY_PACKAGE"/>
and https://google.github.io/styleguide/javaguide.html#s3.3-import-statements for details.

This PR updates the screenshot to a matching IntelliJ configuration.

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@clementdessoude clementdessoude merged commit dd322a3 into jhipster:main Nov 26, 2023
6 checks passed
@koppor koppor deleted the fix-intellij-config branch November 26, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielFran DanielFran DanielFran approved these changes

@clementdessoude clementdessoude Awaiting requested review from clementdessoude

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koppor @CLAassistant @DanielFran @clementdessoude