Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from StyleCI #283

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Apply fixes from StyleCI #283

merged 1 commit into from
Aug 30, 2023

Conversation

joelbutcher
Copy link
Owner

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

@joelbutcher joelbutcher merged commit 66b1cb4 into feat/slack Aug 30, 2023
11 checks passed
@joelbutcher joelbutcher deleted the analysis-APJxJy branch August 30, 2023 14:35
@what-the-diff
Copy link

what-the-diff bot commented Aug 30, 2023

PR Summary

  • Introduced new library references
    The libraries JoelButcher\Socialstream\ConnectedAccount, Illuminate\Support\Str, JoelButcher\Socialstream\Contracts\CreatesUserFromProvider, JoelButcher\Socialstream\Contracts\SetsUserPasswords, and JoelButcher\Socialstream\Contracts\UpdatesConnectedAccounts have been imported into various files, introducing new functions and capabilities that they provide.

  • Removed unused library references
    Cleaner code was achieved by removing unused library references from multiple files. This includes references to DateTimeInterface, App\Models\User, JoelButcher\Socialstream\Tests\TestCase, and other libraries that were not needed in the respective files.

  • Code format improvement
    The code readability was improved by adding spaces around the arguments in various functions such as bitbucket(), facebook(), github(), gitlab(), google(), linkedin(), slack(), twitter(), twitterOAuth1(), and twitterOAuth2(). Similarly, space before if conditions in the switchConnectedAccount function is also now introduced. This makes it easier to understand and follow the logic within the code.

joelbutcher added a commit that referenced this pull request Aug 30, 2023
* Bump socialite to add support for slack

* Add livewire to dev deps

* Add slack support

* Apply fixes from StyleCI (#283)

Co-authored-by: StyleCI Bot <[email protected]>

---------

Co-authored-by: StyleCI Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants