Newer Servant #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allow custom port for toxiproxy (#1) * pin nixpkgs rev * allow custom port for toxiproxy * export BaseUrl
|
@jpittis ping, we're getting compile errors trying to use this package. Looks like this PR implements the fix. |
|
Unfortunately I'm in a situation where I haven't written any Haskell since this project was posted, and I'm not sufficiently familiar with nix to review the contents of this pull request. If one of you is using this repository for something serious with a meaningful maintenance horizon, can I suggest that you fork the repo and take over maintenance via the fork. I'd be willing to merge this PR if it didn't include the nix additions as the code changes look good enough for me. |
|
@Fresheyeball gentle ping, how would you feel about splitting the nix and haskell changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for newer versions of Servant
Nix support