Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pie-lottie-player): DSW-2365 add pie-lottie-player #195

Merged
merged 13 commits into from
Sep 16, 2024
Merged

feat(pie-lottie-player): DSW-2365 add pie-lottie-player #195

merged 13 commits into from
Sep 16, 2024

Conversation

fernandofranca
Copy link
Contributor

@fernandofranca fernandofranca commented Sep 9, 2024 •
edited
Loading

  • Adds pages for the new component for the vanilla, next 13, next 14 and nuxt apps
  • Adds the PERCY=true as URL parameter to visual tests, so we can switch components behaviour when performing VRT
  • Creates the possibility of adding a pause before taking screenshots

@fernandofranca fernandofranca self-assigned this Sep 9, 2024
@fernandofranca fernandofranca marked this pull request as ready for review September 10, 2024 09:06
@xander-marjoram
Copy link
Contributor

xander-marjoram commented Sep 10, 2024 •
edited
Loading

I like the "load another animation" button on the Vanilla app 🚀 Will that be implemented for the other apps too?

@fernandofranca
Copy link
Contributor Author

@xander-marjoram Easy! 😄

kevinrodrigues
kevinrodrigues previously approved these changes Sep 11, 2024
View reviewed changes
@fernandofranca fernandofranca force-pushed the dsw-2365-lottie-player branch 2 times, most recently from 9d20b65 to 90a412d Compare September 11, 2024 15:25
@fernandofranca
DSW-2365: Use webc package
89b614f
@fernandofranca
DSW-2365: Update yarn.lock
c86f9bc 
DSW-2365: Update yarn.lock

DSW-2365: Update yarn.lock

DSW-2365: Update yarn.lock
@fernandofranca
DSW-2365: Update packages
0d13b63 
DSW-2365: Update packages

DSW-2365: Update packages

DSW-2365: Update packages

DSW-2365: Update packages
@kevinrodrigues kevinrodrigues merged commit 6b8b317 into main Sep 16, 2024
19 checks passed
@kevinrodrigues kevinrodrigues deleted the dsw-2365-lottie-player branch September 16, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrodrigues kevinrodrigues kevinrodrigues approved these changes

@xander-marjoram xander-marjoram xander-marjoram approved these changes

Assignees

@fernandofranca fernandofranca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernandofranca @xander-marjoram @kevinrodrigues