DSW-2307: Add new pages for pie-radio #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xander-marjoram
force-pushed
the
dsw-2307-pie-radio
branch
from
6435478
to
ee13ee0
Compare
kevinrodrigues
approved these changes
Oct 1, 2024
siggerzz
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and update the existing form pages to add a fieldset with two
pie-radioelements.I also did some small linting fixes while I was here.
Known issues
pie-radioinputs do not respond when another radio with the same name is updated, I think this should probably be resolved as part of thepie-radio-groupimplementation.changeevent being picked up in Next.inputis being used at the moment in its place.