Update rekordbox formats #696
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have been proven to work in the context of my Beat Link Trigger project, enabling it to retrieve the database over NFS, parse it, and extract all the track metadata it needs even when it is impossible to connect to the database server running on the players because there are four of them in use.
Another good suggestion from @KOLANICH
Trying to use an enum causes unavoidable parse errors in Java and Python when new/unknown FourCC values are encountered. See kaitai-io/kaitai_struct#300
@iamtunzor_twitter found media where there were different values for the artist row, which was causing total database parse failure. Now we should be robust as long as there are no actual structural changes.
Thanks to @iamtunzor_twitter in Croatia for getting his DJ to share a copy of the problematic database file with me!
Now has a much clearer structure in the .ksy *and* provides a single, unified API for the struct user to access the name however it was stored.
|
This supersedes #116, right? |
|
Yes, I forgot that that was never merged, we’ve been using these files productively for years now! Shall I just close the old one? |
|
Alternately, I could merge this branch into #116 and close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized that I have made many important additions and fixes to these formats since I last shared them with this project.