Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redacted for UIViewRepresentable views #788

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

sjavora
Copy link
Member

@sjavora sjavora commented Mar 27, 2024

All SwiftUI components already worked with redacted(...). The problem were those backed by UIKit - text would just show up. Fixed by setting the text to clear color if redaction is detected. The table illustrates most of the fixes.

unredacted redacted before fix redacted after fix
unredacted redacted_before redacted_after

Closes #787.

@sjavora sjavora added the enhancement New feature or request label Mar 27, 2024
@sjavora sjavora requested a review from PavelHolec March 27, 2024 11:55
@sjavora sjavora self-assigned this Mar 27, 2024
@sjavora sjavora requested a review from a team as a code owner March 27, 2024 11:55
@PavelHolec PavelHolec added bug Something isn't working and removed enhancement New feature or request labels Mar 27, 2024
@sjavora sjavora merged commit 3fa4307 into main Mar 27, 2024
6 checks passed
@sjavora sjavora deleted the 787-redacted-uiviewrepresentables branch March 27, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update components to work with redacted()
2 participants