Fix emoji parser for +1 emoji #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F10203040f
approved these changes
Jun 8, 2024
| @@ -15,7 +15,7 @@ class GFM | |||
|
|
|||
| EMOJI_NAMES = Emoji.all.flat_map(&:aliases).freeze | |||
| REGISTRY = EMOJI_NAMES.zip(EMOJI_NAMES).to_h.freeze | |||
| EMOJI_PATTERN = /:(\w+):/ | |||
| EMOJI_PATTERN = /:([\w\+]+):/ | |||
There was a problem hiding this comment.
This is not covering 👎🏾 / - is not part of the character class matched by \w, and you shouldn't need to escape + if it's inside of a character class ([ ] \ - ^ are the characters that would need escaping):
Suggested change
| EMOJI_PATTERN = /:([\w\+]+):/ | |
| EMOJI_PATTERN = /:([\w\-+]+):/ |
That said, there are a lot of places that don't support +1/-1, they are effectively aliases that were added to gemoji that map to the actual unicode CLDR short names (thumbs up and thumbs down)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the 😄 emoji is correctly output, but the 👍 is not.