Add C++20 three-way comparison operator #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is what the Test workflow looks like : It initiates the work depicted in #44 |
Farigh
changed the title
Farigh
force-pushed
the
add-cpp20-three-way-comparison-operator
branch
from
077f6f2
to
6382590
Compare
Farigh
force-pushed
the
add-cpp20-three-way-comparison-operator
branch
from
6382590
to
c8e7b64
Compare
The new operator, also known as `spaceship operator` was introduced in the C++20 standard. The NSIQ parser now handles it properly.
The commit 430a4e7 changed the rule processing to include comment rules. The RULE_4_1_A_A expected to NOT run on comments. The rule was updated to exclude comment lines.
The github action will run both test-suites: - rules - nsiqunittest
|
@kunaltyagi do you plan on merging this at some point by any chance? |
|
@Farigh I'm a contributor, couldn't find your email, drop me a line at [email protected] |
kunaltyagi
reviewed
Oct 8, 2023
kunaltyagi
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new operator, also known as the spaceship operator, was introduced in the C++20 standard.
The NSIQ parser now handles it properly.
I fixed some tests as well in this PR and added a GitHub Action to ensure this is performed for each PR from now on.
I greatly encourage you to enforce Checks on PR merge, this can be found in the branch protection settings :