ref: Add ruff rules RUF #4001
Merged
ref: Add ruff rules RUF #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
cbornet
commented
Oct 3, 2024
Comment on lines
+198
to
+207
| "RUF006", # TODO (Store a reference to the return value of `asyncio.create_task`) | ||
| "RUF012", # TODO (Mutable class attributes should be annotated with `typing.ClassVar`) |
There was a problem hiding this comment.
At the moment I ignore these rules as they deserve some discussion.
There was a problem hiding this comment.
As for RUF012, there seems to be an issue in ruff not detecting pydantic models. Ruff should normally ignore pydantic models for this rule as pydantic does a deep copy of default objects.
There was a problem hiding this comment.
I opened astral-sh/ruff#13630
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
cbornet
commented
Oct 3, 2024
| @@ -53,7 +53,7 @@ def update_build_config(self, build_config: dotdict, field_value: Any, field_nam | |||
| # Add inputs to the build config | |||
| build_config = self.add_inputs_to_build_config(inputs, build_config) | |||
| except Exception as e: | |||
| logger.error(f"Error getting flow {field_value}: {str(e)}") | |||
| logger.error(f"Error getting flow {field_value}: {e}") | |||
There was a problem hiding this comment.
Maybe we could use logger.exception here and remove the error from the message as it will be in the traceback ?
cbornet
commented
Oct 3, 2024
src/backend/base/langflow/components/embeddings/AzureOpenAIEmbeddings.py
Show resolved
Hide resolved
cbornet
force-pushed
the
ruff-rules-ruf
branch
2 times, most recently
from
8798c94
to
35342ab
Compare
ogabrielluiz
force-pushed
the
ruff-rules-ruf
branch
from
35342ab
to
2a3edfc
Compare
cbornet
force-pushed
the
ruff-rules-ruf
branch
6 times, most recently
from
c967c87
to
ed87d64
Compare
cbornet
force-pushed
the
ruff-rules-ruf
branch
from
084a5c3
to
b0338b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ruff rules RUF