-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add LM Studio Model and Embeddings Component #4021
base: main
Are you sure you want to change the base?
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
if output_schema_dict: | ||
output = output.with_structured_output(schema=output_schema_dict, method="json_mode") # type: ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using it today (loving it, btw) and it seems it has to be json_schema. We need to update this (and the OpenAI component) to make this work better with BaseModel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using it today (loving it, btw) and it seems it has to be json_schema. We need to update this (and the OpenAI component) to make this work better with BaseModel
By OpenAI component, you mean OpenAIModel.py
right?
If I understand correctly, all what needs to be done is to swap method="json_mode"
for method="json_schema"
in both LMStudioModel.py
and OpenAIModel.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @EDLLT
Looking good
I guess I'll do what the dosu bot suggested |
Hey @EDLLT Something like this:
|
Hey, so I've fixed the concatenation issue(dosu bot's pretty useful id say) All what remains is the json schema comment you had made. I'm not completely sure what json mode is supposed to do either so maybe it's not supported by lm studio and should be removed? |
Fixes #3973