Add calculateTaxes to HandleTaxes #1589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style compliance
style compliance
style compliance
|
Drafting until reviewed by @driesvints |
|
Hi @victoralbino. Why do you need this? |
|
I sent this PR for an improvement in the issue solution #1585 . The idea was to separate the tax_id_collection check into a separate function in the HandlesTaxes.php trait |
|
Thank you. I don't immediately see the need for this at this time. If you have a practical use of this feel free to share it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding : #1585
In addition of : #1588