Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.x] Add stripe invoice mixin to invoice #1685

Closed
wants to merge 1 commit into from

Conversation

olivernybroe
Copy link

When using the Invoice class, phpstan and IDE's won't be able to access any of the Stripe props, as the class is missing a mixin annotation.

@driesvints
Copy link
Member

Thanks @olivernybroe. There's a couple more of these sorts of wrapper classes. Could you update all of them as well?

@driesvints driesvints changed the title chore: add stripe invoice mixin to invoice [15.x] dd stripe invoice mixin to invoice Jul 1, 2024
@driesvints driesvints changed the title [15.x] dd stripe invoice mixin to invoice [15.x] Add stripe invoice mixin to invoice Jul 1, 2024
@driesvints
Copy link
Member

Just to check: the mixin annotation won't also suggest method calls? Because that's not being forwarded, only properties.

@olivernybroe
Copy link
Author

@driesvints Ah, I totally missed that we were not forwarding methods also.

Yeah then this approach won't work as it will also forward the method calls.
Only way to do it then is to add all props as @property tags, but I don't think maintaining that list of props is a good approach.

I'll might create a ticket with larastan and laravel idea instead 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants