Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.x] Catch missing payment intents #1704

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

shatterproof
Copy link
Contributor

This gracefully returns a not found exception instead of a 500 error when trying to access a non-existent or invalid payment intent ID in the browser such as from the route /stripe/payment/xxx.

@taylorotwell taylorotwell marked this pull request as draft August 12, 2024 21:59
@shatterproof
Copy link
Contributor Author

This was marked as a draft but should be ready to go, let me know if you need any changes @driesvints

@shatterproof shatterproof marked this pull request as ready for review August 19, 2024 15:54
Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shatterproof

@taylorotwell taylorotwell merged commit d6f5ec0 into laravel:15.x Aug 20, 2024
7 checks passed
@shatterproof shatterproof deleted the intent-catch branch August 20, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants