Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing event meter tests #1707

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Fix failing event meter tests #1707

merged 1 commit into from
Aug 19, 2024

Conversation

Bark-fa
Copy link
Contributor

@Bark-fa Bark-fa commented Aug 19, 2024

This should fix the issue in the ManagesUserBilling trait, tests passed locally

@driesvints driesvints merged commit b7b5a45 into laravel:15.x Aug 19, 2024
9 checks passed
@driesvints
Copy link
Member

Thanks!

@driesvints
Copy link
Member

@Bark-fa
Copy link
Contributor Author

Bark-fa commented Aug 19, 2024

I see it's failing on Laravel 10, is there any way I can test this locally? That's a very odd thing

@driesvints
Copy link
Member

You can use composer require "illuminate/contracts=^10" --no-update to install Laravel v10 components to run the test suite.

@Bark-fa
Copy link
Contributor Author

Bark-fa commented Aug 19, 2024

I just did, and the tests pass, is there any difference between what I would have by executing the composer command you gave me and the environment in which the tests are running? and what about the environment where the PR tests are getting evaluated on push?

@driesvints
Copy link
Member

Did you hook up your stripe testing env? See https://github.com/laravel/cashier-stripe/blob/15.x/.github/CONTRIBUTING.md

@Bark-fa
Copy link
Contributor Author

Bark-fa commented Aug 19, 2024

Yes I made sure of it, also ran it before I added the key just to make sure it throws a different kind of error

@driesvints
Copy link
Member

Then I don't know what's different besides the PHP versions. In any case we'll need to get this fixed or I'll have to revert all before tomorrow when we do releases.

@Bark-fa
Copy link
Contributor Author

Bark-fa commented Aug 19, 2024

Shot in the dark, but I'll try to call sleep(1) after reporting usage, maybe this has something to do with it, is there a way to keep the next PR open and still run the action?

@driesvints
Copy link
Member

Yeah just put it in draft and you can play around with it 👍

driesvints added a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants