-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing event meter tests #1707
Conversation
Thanks! |
@Bark-fa tests still fail it seems: https://github.com/laravel/cashier-stripe/actions/runs/10452831229/job/28942077001 |
I see it's failing on Laravel 10, is there any way I can test this locally? That's a very odd thing |
You can use |
I just did, and the tests pass, is there any difference between what I would have by executing the composer command you gave me and the environment in which the tests are running? and what about the environment where the PR tests are getting evaluated on push? |
Did you hook up your stripe testing env? See https://github.com/laravel/cashier-stripe/blob/15.x/.github/CONTRIBUTING.md |
Yes I made sure of it, also ran it before I added the key just to make sure it throws a different kind of error |
Then I don't know what's different besides the PHP versions. In any case we'll need to get this fixed or I'll have to revert all before tomorrow when we do releases. |
Shot in the dark, but I'll try to call sleep(1) after reporting usage, maybe this has something to do with it, is there a way to keep the next PR open and still run the action? |
Yeah just put it in draft and you can play around with it 👍 |
This reverts commit b7b5a45.
This should fix the issue in the ManagesUserBilling trait, tests passed locally