Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to crosshair cursor in plot area #987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PabloAlexis611
Copy link

I think using a crosshair cursor style over the default pointer allows the user to better understand what data point they're hovering on. Makes it easier to connect x/y axis values visually in the plot .

@leeoniya
Copy link
Owner

interesting. i'm not sure this is a good default since uPlot has its own crosshairs and cursors often are rendered with shadows and if the alignment isnt perfectly on-center it can be quite distracting:

image

@PabloAlexis611
Copy link
Author

Mmm, that's interesting - I had never noticed that slight off-center issue.

From my experience I found it more distracting to have a regular pointer cursor because I see a different shape that isn't "connected" in a way to what I'm trying to hover - the default uPlot crosshairs are great, but I liked the extra highlight on what I'm selecting with a crosshair cursor instead.

I probably didn't notice the offset/shadow since I set my background to a darker color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants