fix: when power governer changed, mode not changed #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decodetalkers
force-pushed
the
support_fsnotify
branch
from
5265a8d
to
5430261
Compare
dengbo11
reviewed
Sep 13, 2023
system/power1/manager.go
Outdated
| return | ||
| } | ||
|
|
||
| defer watcher.Close() |
Decodetalkers
force-pushed
the
support_fsnotify
branch
from
5430261
to
50c69f9
Compare
dengbo11
requested changes
Sep 13, 2023
system/power1/manager.go
Outdated
Comment on lines
183
to
194
| data, err := os.ReadFile(pstateConfPath) | ||
| if err == nil { | ||
| status := strings.TrimSpace(string(data)) | ||
| if status == m.balanceScalingGovernor { | ||
| m.emitPropChangedMode("balance") | ||
| } else if status == "performance" { | ||
| m.emitPropChangedMode("performance") | ||
| } else if status == "power" { | ||
| m.emitPropChangedMode("powersave") | ||
| } else { | ||
| logger.Debug("Unknown status:", status) | ||
| } |
Decodetalkers
force-pushed
the
support_fsnotify
branch
3 times, most recently
from
c17e45d
to
e71dd5c
Compare
dengbo11
previously approved these changes
Sep 13, 2023
Decodetalkers
force-pushed
the
support_fsnotify
branch
4 times, most recently
from
8a96ca6
to
57bf736
Compare
dengbo11
previously approved these changes
Sep 13, 2023
Decodetalkers
force-pushed
the
support_fsnotify
branch
from
57bf736
to
4a785d2
Compare
dengbo11
reviewed
Sep 13, 2023
system/power1/manager.go
Outdated
Comment on lines
243
to
241
| } else { | ||
| continue | ||
| } | ||
|
|
||
| if err != nil { | ||
| logger.Debug("Read file error: ", err) | ||
| continue | ||
| } | ||
| if modeAndgovData.mode != "" { | ||
| m.setPropMode(modeAndgovData.mode) | ||
| m.setPropCpuGovernor(modeAndgovData.governor) | ||
| } |
There was a problem hiding this comment.
if (err ==nil && modeAndgovData.mode != "") {
m.setPropMode(modeAndgovData.mode)
m.setPropCpuGovernor(modeAndgovData.governor)
}
Decodetalkers
force-pushed
the
support_fsnotify
branch
2 times, most recently
from
1eb9006
to
e62deea
Compare
dengbo11
previously approved these changes
Sep 13, 2023
Decodetalkers
force-pushed
the
support_fsnotify
branch
from
e62deea
to
035024c
Compare
Log: this add a fsnotify
Decodetalkers
force-pushed
the
support_fsnotify
branch
from
035024c
to
aadfc53
Compare
dengbo11
approved these changes
Sep 14, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Decodetalkers, dengbo11 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/integrate |
|
AutoIntegrationPr Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log: this add a fsnotify