Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: archlinux build error #623

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: archlinux build error #623

merged 1 commit into from
Jun 19, 2024

Conversation

hudeng-go
Copy link
Contributor

@hudeng-go hudeng-go commented Apr 19, 2024 •
edited
Loading

高版本ddcutil需要单独添加ddcutil_types.h才能保证cgo能正常构建

log:

@hudeng-go
Copy link
Contributor Author

需要deepin-community/ddcutil#1 先集成。

@hudeng-go
Copy link
Contributor Author

/hold

@hudeng-go
Copy link
Contributor Author

/cc @wineee

@hudeng-go
Copy link
Contributor Author

/cc @zsien

@wineee
Copy link
Member

wineee commented Apr 19, 2024 •
edited
Loading

等下， deepin 构建挂了

upd： 可能要等集成

wineee

This comment was marked as outdated.

Sign in to view

@wineee wineee mentioned this pull request Apr 19, 2024
Closed
zsien
zsien previously approved these changes Apr 19, 2024
View reviewed changes
wineee
wineee previously approved these changes Apr 19, 2024
View reviewed changes
@hudeng-go hudeng-go dismissed stale reviews from wineee and zsien via 623a183 April 23, 2024 05:32
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 23, 2024

TAG Bot

New tag: 6.0.38
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #626

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 30, 2024

TAG Bot

New tag: 6.0.39
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #628

@wineee
Copy link
Member

wineee commented May 14, 2024

这个 pr 可以合吗？

@BLumia BLumia requested review from zsien and dengbo11 May 21, 2024 03:14
@hudeng-go
Copy link
Contributor Author

/hold

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 5, 2024

TAG Bot

New tag: 6.0.40
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #632

@hudeng-go hudeng-go force-pushed the master branch 2 times, most recently from 9be286c to b278b0e Compare June 5, 2024 08:47
@hudeng-go
fix: archlinux build error
d4aa7a3 
高版本ddcutils需要单独添加ddcutil_types.h才能保证cgo能正常构建

log:
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在newDDCCI函数中，C.ddca_init2函数调用缺少了C.DDCA_INIT_OPTIONS_CLIENT_OPENED_SYSLOG选项，可能会影响初始化行为。
  • C.CString函数的使用应该确保字符串在C中是安全的，避免内存泄露。
  • filepath.Join函数的使用应该检查content变量是否为空，以避免潜在的空指针异常。
  • 错误消息的更改应该反映实际的错误原因，而不是仅仅替换字符串。

是否建议立即修改:
是

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hudeng-go, justforlxz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justforlxz justforlxz merged commit 32ffa1a into linuxdeepin:master Jun 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justforlxz justforlxz justforlxz approved these changes

@wineee wineee wineee left review comments

@zsien zsien Awaiting requested review from zsien

@dengbo11 dengbo11 Awaiting requested review from dengbo11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hudeng-go @wineee @deepin-ci-robot @zsien @justforlxz