Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/run-benchmark.rb: support recent versions of CRuby. #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sisshiki1969
Copy link
Sponsor Contributor

Hi, mame-san.

This PR aims to add some DockerImage's used in run-benchmark.rb for catching up recent release's of CRuby.

  • Add Ruby32 and Ruby33 (actually, it means 3.3-rc).
  • Add Ruby32YJIT and Ruby33YJIT (actually, it means 3.3-rc).
  • Rename MasterMJIT to MasterYJIT because the current master branch of ruby/ruby supports only RJIT (and YJIT) instead of MJIT.
  • Add Ruby33RJIT (actually, it means 3.3-rc).
  • Use base image "rust:latest" for MasterYJIT because current YJIT needs rustc to build.
    In addition, use ./autogen.sh instead of autoconf because configure caused an error below in my environment.
❯ ruby tools/run-benchmark.rb masteryjit
tools/run-benchmark.rb:2: warning: csv which will be not part of the default gems since Ruby 3.4.0
+------------------+
| build masteryjit |
+------------------+
[+] Building 3.4s (12/14)                                                                                                                                                                                                                                                      
 => [internal] load build definition from Dockerfile.masteryjit                                                                                                                                                                                                           0.0s
 => => transferring dockerfile: 539B                                                                                                                                                                                                                                      0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                                         0.0s
 => => transferring context: 35B                                                                                                                                                                                                                                          0.0s
 => [internal] load metadata for docker.io/library/rust:latest                                                                                                                                                                                                            2.8s
 => [auth] library/rust:pull token for registry-1.docker.io                                                                                                                                                                                                               0.0s
 => [1/9] FROM docker.io/library/rust:latest@sha256:911acdfd39276ead0dfb583a833f1db7d787ad0d5333848378d88f19e5fc158c                                                                                                                                                      0.0s
 => [internal] load build context                                                                                                                                                                                                                                         0.0s
 => => transferring context: 22.35kB                                                                                                                                                                                                                                      0.0s
 => CACHED [2/9] WORKDIR /root                                                                                                                                                                                                                                            0.0s
 => CACHED [3/9] RUN apt-get update                                                                                                                                                                                                                                       0.0s
 => CACHED [4/9] RUN apt-get install -y autoconf bison build-essential libssl-dev libyaml-dev libreadline6-dev zlib1g-dev libncurses5-dev libffi-dev libgdbm6 libgdbm-dev libdb-dev git ruby                                                                              0.0s
 => CACHED [5/9] RUN git clone --depth 1 https://github.com/ruby/ruby.git                                                                                                                                                                                                 0.0s
 => CACHED [6/9] RUN cd ruby && autoconf                                                                                                                                                                                                                                  0.0s
 => ERROR [7/9] RUN cd ruby && ./configure --prefix=`pwd`/local                                                                                                                                                                                                           0.5s
------                                                                                                                                                                                                                                                                         
 > [7/9] RUN cd ruby && ./configure --prefix=`pwd`/local:
#11 0.486 configure: error: cannot find required auxiliary files: config.guess config.sub
------
executor failed running [/bin/sh -c cd ruby && ./configure --prefix=`pwd`/local]: exit code: 1
tools/run-benchmark.rb:80:in `build': unhandled exception
        from tools/run-benchmark.rb:417:in `block in run_benchmark'
        from tools/run-benchmark.rb:443:in `block in each_target_image'
        from tools/run-benchmark.rb:441:in `each'
        from tools/run-benchmark.rb:441:in `each_target_image'
        from tools/run-benchmark.rb:415:in `run_benchmark'
        from tools/run-benchmark.rb:407:in `main'
        from tools/run-benchmark.rb:534:in `<main>'

@sisshiki1969 sisshiki1969 changed the title Add DockerImage's for recent versions of CRuby. tools/run-benchmark.rb: support recent versions of CRuby. Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant