Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(product): fix product variant update price with min_quantity and max_quantity #9381

Open
wants to merge 4 commits into
base: v1.x
Choose a base branch
from

Conversation

BeyondOT
Copy link

What :

The issue is updating the variant price with min_quantity and max_quantity always returned null for both these attributes. Which is not the expected behaviour based on the admin api reference. https://docs.medusajs.com/api/admin#products_postproductsproductvariantsvariant

How :

Make sure to include all the attributes when updating the variant price.

Testing:

Update variant price through api including min_quantity and max_quantity.

@BeyondOT BeyondOT requested a review from a team as a code owner September 30, 2024 09:19
Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: 6554a55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 30, 2024

@BeyondOT is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@BeyondOT
Copy link
Author

I just added a commit that fixes the unit test error.

The price update fix was made by spreading the price object in money amount so the test should expect the currency code to be there as well if it was included in the price object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants