Skip to content

Commit

Permalink
loosen the versionPath requirements (#20)
Browse files Browse the repository at this point in the history
# Thanks for opening a Pull Request

## Changes

Please outline the reason for the changes you are making:

In some use cases, users may not want to use the version interpolation,
but instead specify a hard-coded versionPath
to resolve a dependency to. This change would allow the `versionPath`
property of a registration to be a specified version.

Are there any breaking changes you are aware of in the PR?

No

If yes, what are they?

## General Checklist

* [ ] Change is tested locally
* [ ] Demo is updated to exercise change (if applicable)
* [ ] [WIP] flag is removed from the title

[1]:https://docs.npmjs.com/about-semantic-versioning
[2]:https://docs.npmjs.com/cli/deprecate

[3]:https://github.com/meltwater/applet-orchard/blob/master/docs/README.md

---------

Co-authored-by: Joe Theriault <[email protected]>
  • Loading branch information
mattquinlan440 and jtheriault authored Aug 18, 2023
1 parent 7dc65b2 commit 4f1d78b
Show file tree
Hide file tree
Showing 6 changed files with 1,086 additions and 583 deletions.
14 changes: 14 additions & 0 deletions demo/orchard/nop.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
'nop':
# Ownership information
ownedBy: supershabam
repo: https://github.com/supershabam/nop
contact:
url: https://github.com/supershabam/nop/issues
# Technical Details
basePath: https://unpkg.com/npm@
esm:
- /index.js
# This is to confirm values without `{{version}}` will work
versionPath: '1.0.0'
conflictsWithOtherMajorVersions: true
requiresInitialization: false
Loading

0 comments on commit 4f1d78b

Please sign in to comment.