Systemjs depcache output #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshsusai
reviewed
Jul 10, 2024
src/build-depcache-output/resolve-required-dependency-scripts/index.js
Outdated
Show resolved
Hide resolved
jtheriault
reviewed
Jul 10, 2024
| .help('-h, --help') | ||
| .parseAndExit() | ||
| .then(options => ({ ...options, logging: loggingMap[options.logging] })) | ||
| .then(options => new CliOptions(options)) | ||
| .then(cliOptions => buildAppOutput(cliOptions)) | ||
| .then(cliOptions => { | ||
| if(cliOptions.outputDepcache) { |
There was a problem hiding this comment.
Could we get a description and/or sample in the README of what this is and does?
There was a problem hiding this comment.
Added something to the README. Let me know if it's enough, or more details are needed
There was a problem hiding this comment.
That does the job nicely. Thank you
krishna-koushik
approved these changes
Jul 10, 2024
jtheriault
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for opening a Pull Request
Changes
Please outline the reason for the changes you are making:
This PR adds the ability to output the scripts in a
depcacheformat that's usable with single SPA / systemjs implementations[Change description here]
Are there any breaking changes you are aware of in the PR?
Not directly. Updating arborist a major version, but its downstream change removed node versions we already didn't support.
General Checklist