-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change support of ThermoPro TX-2C sensor to enable reading humidity data #2514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. We need to think about subtype
as that would be a breaking change.
Is it really a fixed model code or maybe a variable preamble?
I took subtype from another ThermoPro device : rtl_433/src/devices/thermopro_tx2.c Lines 70 to 90 in ac36025
It's not useful to me. If you think it's better not to output it, I can change that. All other requested changes have been resolved |
Just comment out ( |
PR updated to comment subtype output. |
Hi,
I've added some more information on ThermoPro TX-2C when a humidity sensor is available.
Decoding pattern is similar to other ThermoPro devices.
There is working tests in rtl_433_tests in another pull request (merbanan/rtl_433_tests#453)