Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of running ninja directly #13546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reftel
Copy link

@reftel reftel commented Aug 15, 2024

It may be true that if one uses a Meson version that is more than 4 years old, one might need to run ninja directly, but details like that should be safe to keep out of the simple getting started guide.

It may be true that if one uses a Meson version that is more than 4 years old, one might need to run `ninja` directly, but details like that should be safe to keep out of the simple getting started guide.
@reftel reftel requested a review from jpakkane as a code owner August 15, 2024 12:18
Copy link
Member

@eli-schwartz eli-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I strongly disagree and think that ninja should always be used specifically, no matter how new meson is, except specifically when using MSVC due to this bug: ninja-build/ninja#1610

meson compile is badly designed and cannot be fixed without breaking existing users. I've had to roll back its usage elsewhere in order to re-enable fundamental features of ninja-based workflows that were broken by using meson compile.

But I appear to be in the minority about thinking this...

@dcbaker
Copy link
Member

dcbaker commented Aug 15, 2024

I agree with @eli-schwartz, I wish I'd never written meson compile. I had hoped for something that could be used in cases where compatibility between backends was more important than feature richness, like in CI's where people basically wanted build, use X cores, test. the whole point was to avoid:

if windows:
   msbuild /MP:8 ...
else:
  ninja -j8 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants