Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accept Header to wrap requests #13709

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Sep 24, 2024

This is a follow on to the original change in b1abfa8. curl also sets request headers to use this value by default, which can be helpful when trying to connect to sites with very strict content negotiation requirements

This is a follow on to the original change in b1abfa8. curl also
sets request headers to use this value by default, which can be
helpful when trying to connect to sites with very strict content
negotiation requirements
@dcbaker
Copy link
Member

dcbaker commented Sep 24, 2024

I wonder if we actually want to present a more realistic set of mime types we accept, or at least weight the kinds we expect higher than ones we don't. Though maybe that will get us into trouble with poorly behaved sites? @eli-schwartz what do you think?

@eli-schwartz
Copy link
Member

The first thing that leaps to mind is: what happens on download sites that transparently generate metalink manifests if they detect that the download agent supports them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants