curses: Ignore /usr/bin/ncurses5.4-config on macOS #13715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirbheek
added
OS:macos
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -52,7 +52,7 @@ | |||
| req_version = mesonlib.stringlistify(req_version_raw) | |||
| else: | |||
| req_version = [] | |||
| tool, version = self.find_config(req_version, kwargs.get('returncode_value', 0)) | |||
| tool, version = self.find_config(req_version, kwargs.get('returncode_value', 0), exclude_paths=exclude_paths) | |||
Check warning
Code scanning / CodeQL
`__init__` method calls overridden method Warning
nirbheek
force-pushed
the
ncurses-macos
branch
from
d3ae4c2
to
7d7baf7
Compare
|
This is a simple enough change, so I will merge in 1 week if there are no objections. |
dcbaker
reviewed
Sep 30, 2024
nirbheek
force-pushed
the
ncurses-macos
branch
from
7d7baf7
to
7b93f12
Compare
dcbaker
approved these changes
Oct 3, 2024
macOS mistakenly ships /usr/bin/ncurses5.4-config and a man page for it, but none of the headers or libraries are available in the location advertised by it. Ignore /usr/bin because it can only contain this broken configtool script. Homebrew is /usr/local or /opt/homebrew. Xcode's command-line tools SDK does include curses, but the configtool in there is wrong too, and anyway we can't just randomly pick it up since the user must explicitly select that as a target by using a native file. The MacOSX SDK itself does not include curses. We also can't ignore ncurses5.4-config entirely because it might be available in a different prefix.
nirbheek
force-pushed
the
ncurses-macos
branch
from
7b93f12
to
c7dac28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS mistakenly ships
/usr/bin/ncurses5.4-configand a man page for it, but none of the headers or libraries are available in the location advertised by it. Ignore/usr/binbecause it can only contain this broken configtool script. Homebrew is /usr/local or/opt/homebrew.Xcode's command-line tools SDK does include curses, but the configtool in there is wrong too, and anyway we can't just randomly pick it up since the user must explicitly select that as a target by using a native file. The MacOSX SDK itself does not include curses.
We also can't ignore ncurses5.4-config entirely because it might be available in a different prefix.