CMake minimum version 3.10 #13760
Open
CMake minimum version 3.10 #13760
+26
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mitigates maintenance burden as CMake minimum version isn't relevant for these tests. CMake >= 3.31 warns if CMake minimum version is less than 3.10. ref: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9875
eli-schwartz
reviewed
Oct 6, 2024
There was a problem hiding this comment.
Overall this change seems quite reasonable. And 3.5 is certainly not necessary for us anymore since if I recall correctly meson no longer supports versions of cmake below 3.14 for use in subproject() -- which I think is what all this code is related to anyway.
| @@ -212,7 +212,7 @@ def update_cmake_compiler_state(self) -> None: | |||
| languages = list(self.compilers.keys()) | |||
| lang_ids = [language_map.get(x, x.upper()) for x in languages] | |||
| cmake_content = dedent(f''' | |||
| cmake_minimum_required(VERSION 3.7) | |||
| cmake_minimum_required(VERSION 3.10) | |||
There was a problem hiding this comment.
Are we able to get away with the same "whatever the current version is" trick here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mitigates maintenance burden as CMake minimum version isn't
relevant for these tests. CMake >= 3.31 warns if CMake minimum version
is less than 3.10.
ref: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9875