Fix RunSettings/RunConfiguration/ResultsDirectory #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the configuration management in the Microsoft Testing Platform. The key changes include the addition of asynchronous methods for building configuration providers, the introduction of an order property for configuration sources, and updates to unit tests to accommodate these changes.
Configuration Management Enhancements:
src/Platform/Microsoft.Testing.Extensions.VSTestBridge/Configurations/RunSettingsConfigurationProvider.cs: Added an asynchronousBuildAsyncmethod and anOrderproperty to theRunSettingsConfigurationProviderclass. [1] [2] [3] [4]src/Platform/Microsoft.Testing.Platform/Configurations/ConfigurationManager.cs: Updated theBuildAsyncmethod to accept aCommandLineParseResultparameter and order configuration providers based on theirOrderproperty. [1] [2] [3]Asynchronous Configuration Source Methods:
src/Platform/Microsoft.Testing.Platform/Configurations/IConfigurationSource.cs: Added theOrderproperty and changed theBuildmethod toBuildAsync.src/Platform/Microsoft.Testing.Platform/Configurations/EnvironmentVariablesConfigurationSource.cs: Updated to include theOrderproperty and theBuildAsyncmethod.src/Platform/Microsoft.Testing.Platform/Configurations/JsonConfigurationSource.cs: Added theOrderproperty and theBuildAsyncmethod.File System Enhancements:
src/Platform/Microsoft.Testing.Platform/Helpers/System/IFileSystem.cs: Added an asynchronousReadAllTextAsyncmethod.src/Platform/Microsoft.Testing.Platform/Helpers/System/SystemFileSystem.cs: Implemented theReadAllTextAsyncmethod, with conditional compilation for different .NET versions.Unit Tests Updates:
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Configuration/ConfigurationManagerTests.cs: Updated unit tests to use the newBuildAsyncmethod with theCommandLineParseResultparameter. [1] [2] [3] [4] [5] [6]