Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up CODEOWNERS for js-multiformats #83

Closed
wants to merge 34 commits into from

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Sep 25, 2023

FYI, @BigLep, you can create teams and CODEOWNERS file both from GitHub Management (if we want to contain the discussion about both to a single place).

github/multiformats.yml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

multiformats

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # github_repository_file.this["js-multiformats/codeowners"] will be created
  + resource "github_repository_file" "this" {
      + branch              = "master"
      + commit_author       = "GitHub"
      + commit_email        = "[email protected]"
      + commit_message      = "chore: Update CODEOWNERS [skip ci]"
      + commit_sha          = (known after apply)
      + content             = <<-EOT
            *  @multiformats/helia-dev @multiformats/js-libp2p-dev @rvagg @Gozala
        EOT
      + file                = "CODEOWNERS"
      + id                  = (known after apply)
      + overwrite_on_create = false
      + ref                 = (known after apply)
      + repository          = "js-multiformats"
      + sha                 = (known after apply)
    }

  # github_team.this["helia dev"] will be created
  + resource "github_team" "this" {
      + create_default_maintainer = false
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "Helia Dev"
      + node_id                   = (known after apply)
      + privacy                   = "closed"
      + slug                      = (known after apply)
    }

  # github_team.this["js-libp2p-dev"] will be created
  + resource "github_team" "this" {
      + create_default_maintainer = false
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "js-libp2p-dev"
      + node_id                   = (known after apply)
      + privacy                   = "closed"
      + slug                      = (known after apply)
    }

  # github_team_membership.this["github-mgmt stewards:aschmahmann"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6630975:aschmahmann"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

  # github_team_membership.this["github-mgmt stewards:rvagg"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6630975:rvagg"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

  # github_team_membership.this["github-mgmt stewards:vmx"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6630975:vmx"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

  # github_team_membership.this["helia dev:2color"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "2color"
    }

  # github_team_membership.this["helia dev:achingbrain"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "achingbrain"
    }

  # github_team_membership.this["helia dev:sgtpooki"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "SgtPooki"
    }

  # github_team_membership.this["js-libp2p-dev:2color"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "2color"
    }

  # github_team_membership.this["js-libp2p-dev:achingbrain"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "achingbrain"
    }

  # github_team_membership.this["js-libp2p-dev:sgtpooki"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "SgtPooki"
    }

  # github_team_membership.this["js-libp2p-dev:wemeetagain"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "wemeetagain"
    }

Plan: 10 to add, 3 to change, 0 to destroy.

@SgtPooki
Copy link
Contributor

@BigLep action items from yesterday:

  • Codeowners
    • js-libp2p-maintainers
    • helia-maintainers
    • Rod
    • Irakli
  • Message about the plan and link to ownership issue

@BigLep
Copy link
Contributor

BigLep commented Sep 26, 2023

Related ownership issue: multiformats/js-multiformats#273

@achingbrain : please take a look to see if this looks good to you

@BigLep BigLep marked this pull request as ready for review September 26, 2023 22:32
@BigLep BigLep requested review from a team as code owners September 26, 2023 22:32
@@ -2548,6 +2551,14 @@ teams:
member:
- lukehoersten
privacy: closed
Helia Dev:
# This should match https://github.com/orgs/ipfs/teams/helia-dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can codify this! We can add a rule to https://github.com/multiformats/github-mgmt/blob/master/scripts/src/actions/fix-yaml-config.ts that would look up the team members at https://github.com/orgs/ipfs/teams/helia-dev and set them here too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to do this?

github/multiformats.yml Outdated Show resolved Hide resolved
github/multiformats.yml Outdated Show resolved Hide resolved
BigLep and others added 2 commits February 7, 2024 13:31
@BigLep
Copy link
Contributor

BigLep commented Feb 7, 2024

@achingbrain : feedback incorporated. Are you ok to approve/merge?

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending resolving the comment about automating the synching of team members from @galargh.

Copy link
Contributor

github-actions bot commented Feb 16, 2024

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

Terraform plans are too long to post as a comment. Please inspect Plan > Comment > Show terraform plans instead.

@multiformats multiformats deleted a comment from github-actions bot Feb 16, 2024
@galargh
Copy link
Contributor Author

galargh commented Feb 16, 2024

I'm going to close this PR because it got accidentally pulled into testing of other features. I'm going to recreate and merge it after the testing's complete and then I'll report back here that the PR was merged.

@galargh galargh closed this Feb 16, 2024
@galargh galargh deleted the js-multiformats-codeowners branch February 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants