Closes: #17575 - Add NullableMultipleChoiceFilter and filter form UI to match empty string #17576
Conversation
bctiemann
force-pushed
the
17575-nullable-multiple-choice-filter
branch
from
2ad87cb
to
c2473e6
Compare
| @@ -1980,7 +1980,7 @@ class CableFilterSet(TenancyFilterSet, NetBoxModelFilterSet): | |||
| method='_unterminated', | |||
| label=_('Unterminated'), | |||
| ) | |||
| type = django_filters.MultipleChoiceFilter( | |||
| type = NullableMultipleChoiceFilter( | |||
There was a problem hiding this comment.
This addresses the type field on Cable specifically, but I think what we need is a general implementation which covers all non-required choice fields, across all models. Ideally, this should be handled automatically for all model fields with a choices attribute defined, which would obviate the need to manually declare these on the FilterSets as we currently do. (Granted, I'm not sure whether that's feasible.)
| def filter(self, qs, value): | ||
| if settings.FILTERS_NULL_CHOICE_VALUE in value: | ||
| value.append('') | ||
| return super().filter(qs, value) |
There was a problem hiding this comment.
It feels like we need to further consider the implications of storing empty strings rather than null values for these fields. django-filter has native support for the later; replacing empty strings with null would obviate the need for a custom filter entirely AFAICT. Maybe that should be our preferred strategy.
jeremystretch
added
the
status: blocked
Closes: #17575
Adds a
NullableMultipleChoiceFilterclass (patterned on the existingNullableCharFieldFilter) which can be used in a multiple-choice FilterForm input to add the "(unset)" ('') value to a list of acceptable choices in the filter, evaluated in an OR fashion in a single query.