Consistent validation with pydantic & vocpub (disallow None) #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None is not allowed according to the vocpub profile but the pydantic model accepted it. The pydantic model is changed to only allow dates. This also changes the default version from None to "automatic" which conveys more clearly what is happening (version is automatically derived and added in merge CI action of vocabulary).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None is not allowed according to the vocpub profile but the pydantic model accepted it. The pydantic model is changed to also only allow dates. Two tests were wrong and have been changed.
This PR also changes the default version of the concept scheme in CI from
Noneto the string"automatic"which conveys more clearly what is happening: The version is automatically derived and added to the build artifacts but not present in git.Closes #174