Security updates #43
Open
Security updates #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using https and/or httpAdminRoot
Having created a reference to this, it should be used in the code. More consistent and more obvious. Also added reason why node var is created.
Since node is created as a reference to the correct this object, it should be used throughout.
|
Also added some minor tweaks to use the node var instead of this for consistency and more obvious code. |
dceejay
reviewed
May 3, 2017
| In order to retain a consistent reference to the nodes `this`, a variable called | ||
| `node` is created pointing to `this`. `this`/`node` contains the information | ||
| related to the created instance of the node. You would typically pass the nodes | ||
| properties, `config`. to to `node` as well. |
There was a problem hiding this comment.
Haha, well done Dave, you spotted the deliberate typo to make sure you were checking!
Do you want me to change it or will you do it directly? Sorry, not done many PR's and I'm not sure what the normal protocol is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as discussed on Slack.
Added a few clarifying points on security settings.