[TASK] Move the XClass tests to functional tests (#711)

Tests/Unit/Domain/Model/Fixtures/XclassFrontendUser.php → Tests/Functional/Domain/Model/Fixtures/XclassFrontendUser.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace OliverKlee\FeUserExtraFields\Tests\Unit\Domain\Model\Fixtures;
+namespace OliverKlee\FeUserExtraFields\Tests\Functional\Domain\Model\Fixtures;
 
 use OliverKlee\FeUserExtraFields\Domain\Model\FrontendUser;
 

Tests/Unit/Domain/Model/Fixtures/XclassFrontendUserGroup.php → Tests/Functional/Domain/Model/Fixtures/XclassFrontendUserGroup.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace OliverKlee\FeUserExtraFields\Tests\Unit\Domain\Model\Fixtures;
+namespace OliverKlee\FeUserExtraFields\Tests\Functional\Domain\Model\Fixtures;
 
 use OliverKlee\FeUserExtraFields\Domain\Model\FrontendUserGroup;
 

Tests/Functional/Domain/Model/FrontendUserGroupTest.php

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace OliverKlee\FeUserExtraFields\Tests\Functional\Domain\Model;
+
+use OliverKlee\FeUserExtraFields\Domain\Model\FrontendUserGroup;
+use OliverKlee\FeUserExtraFields\Tests\Functional\Domain\Model\Fixtures\XclassFrontendUserGroup;
+use TYPO3\CMS\Core\Utility\GeneralUtility;
+use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;
+
+/**
+ * @covers \OliverKlee\FeUserExtraFields\Domain\Model\FrontendUserGroup
+ */
+final class FrontendUserGroupTest extends FunctionalTestCase
+{
+    protected bool $initializeDatabase = false;
+
+    protected array $testExtensionsToLoad = ['oliverklee/feuserextrafields'];
+
+    /**
+     * @test
+     */
+    public function canBeSubclassed(): void
+    {
+        // @phpstan-ignore offsetAccess.nonOffsetAccessible, offsetAccess.nonOffsetAccessible
+        $xclassConfiguration = &$GLOBALS['TYPO3_CONF_VARS']['SYS']['Objects'];
+        self::assertIsArray($xclassConfiguration);
+        $xclassConfiguration[FrontendUserGroup::class] = ['className' => XclassFrontendUserGroup::class];
+
+        $instance = GeneralUtility::makeInstance(FrontendUserGroup::class);
+
+        self::assertInstanceOf(XclassFrontendUserGroup::class, $instance);
+    }
+}

Tests/Functional/Domain/Model/FrontendUserTest.php

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace OliverKlee\FeUserExtraFields\Tests\Functional\Domain\Model;
+
+use OliverKlee\FeUserExtraFields\Domain\Model\FrontendUser;
+use OliverKlee\FeUserExtraFields\Tests\Functional\Domain\Model\Fixtures\XclassFrontendUser;
+use TYPO3\CMS\Core\Utility\GeneralUtility;
+use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;
+
+/**
+ * @covers \OliverKlee\FeUserExtraFields\Domain\Model\FrontendUser
+ */
+final class FrontendUserTest extends FunctionalTestCase
+{
+    protected bool $initializeDatabase = false;
+
+    protected array $testExtensionsToLoad = ['oliverklee/feuserextrafields'];
+
+    /**
+     * @test
+     */
+    public function canBeSubclassed(): void
+    {
+        // @phpstan-ignore offsetAccess.nonOffsetAccessible, offsetAccess.nonOffsetAccessible
+        $xclassConfiguration = &$GLOBALS['TYPO3_CONF_VARS']['SYS']['Objects'];
+        self::assertIsArray($xclassConfiguration);
+        $xclassConfiguration[FrontendUser::class] = ['className' => XclassFrontendUser::class];
+
+        $instance = GeneralUtility::makeInstance(FrontendUser::class);
+
+        self::assertInstanceOf(XclassFrontendUser::class, $instance);
+    }
+}

Tests/Unit/Domain/Model/FrontendUserGroupTest.php

@@ -5,8 +5,6 @@
 namespace OliverKlee\FeUserExtraFields\Tests\Unit\Domain\Model;
 
 use OliverKlee\FeUserExtraFields\Domain\Model\FrontendUserGroup;
-use OliverKlee\FeUserExtraFields\Tests\Unit\Domain\Model\Fixtures\XclassFrontendUserGroup;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Extbase\DomainObject\AbstractEntity;
 use TYPO3\CMS\Extbase\Persistence\ObjectStorage;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
@@ -21,19 +19,10 @@ final class FrontendUserGroupTest extends UnitTestCase
     protected function setUp(): void
     {
         parent::setUp();
-        GeneralUtility::flushInternalRuntimeCaches();
 
         $this->subject = new FrontendUserGroup();
     }
 
-    protected function tearDown(): void
-    {
-        // @phpstan-ignore offsetAccess.nonOffsetAccessible, offsetAccess.nonOffsetAccessible
-        unset($GLOBALS['TYPO3_CONF_VARS']['SYS']['Objects']);
-        GeneralUtility::flushInternalRuntimeCaches();
-        parent::tearDown();
-    }
-
     /**
      * @test
      */
@@ -42,21 +31,6 @@ public function isAbstractEntity(): void
         self::assertInstanceOf(AbstractEntity::class, $this->subject);
     }
 
-    /**
-     * @test
-     */
-    public function canBeSubclassed(): void
-    {
-        // @phpstan-ignore offsetAccess.nonOffsetAccessible, offsetAccess.nonOffsetAccessible
-        $xclassConfiguration = &$GLOBALS['TYPO3_CONF_VARS']['SYS']['Objects'];
-        self::assertIsArray($xclassConfiguration);
-        $xclassConfiguration[FrontendUserGroup::class] = ['className' => XclassFrontendUserGroup::class];
-
-        $instance = GeneralUtility::makeInstance(FrontendUserGroup::class);
-
-        self::assertInstanceOf(XclassFrontendUserGroup::class, $instance);
-    }
-
     /**
      * @test
      */

Tests/Unit/Domain/Model/FrontendUserTest.php

@@ -6,8 +6,6 @@
 
 use OliverKlee\FeUserExtraFields\Domain\Model\FrontendUser;
 use OliverKlee\FeUserExtraFields\Domain\Model\FrontendUserGroup;
-use OliverKlee\FeUserExtraFields\Tests\Unit\Domain\Model\Fixtures\XclassFrontendUser;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Extbase\Domain\Model\FileReference;
 use TYPO3\CMS\Extbase\DomainObject\AbstractEntity;
 use TYPO3\CMS\Extbase\Persistence\ObjectStorage;
@@ -23,19 +21,10 @@ final class FrontendUserTest extends UnitTestCase
     protected function setUp(): void
     {
         parent::setUp();
-        GeneralUtility::flushInternalRuntimeCaches();
 
         $this->subject = new FrontendUser();
     }
 
-    protected function tearDown(): void
-    {
-        // @phpstan-ignore offsetAccess.nonOffsetAccessible, offsetAccess.nonOffsetAccessible
-        unset($GLOBALS['TYPO3_CONF_VARS']['SYS']['Objects']);
-        GeneralUtility::flushInternalRuntimeCaches();
-        parent::tearDown();
-    }
-
     /**
      * @test
      */
@@ -44,21 +33,6 @@ public function isAbstractEntity(): void
         self::assertInstanceOf(AbstractEntity::class, $this->subject);
     }
 
-    /**
-     * @test
-     */
-    public function canBeSubclassed(): void
-    {
-        // @phpstan-ignore offsetAccess.nonOffsetAccessible, offsetAccess.nonOffsetAccessible
-        $xclassConfiguration = &$GLOBALS['TYPO3_CONF_VARS']['SYS']['Objects'];
-        self::assertIsArray($xclassConfiguration);
-        $xclassConfiguration[FrontendUser::class] = ['className' => XclassFrontendUser::class];
-
-        $instance = GeneralUtility::makeInstance(FrontendUser::class);
-
-        self::assertInstanceOf(XclassFrontendUser::class, $instance);
-    }
-
     /**
      * @test
      */