Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tutorial: basics of parcel-model ODE system (with a readable minimalistic SciPy+pint solution) #1297

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

bhiogade
Copy link
Contributor

No description provided.

@slayoo slayoo changed the title New Tutorials for Parcel-(Ordinary differential equation) new tutorial: basics of parcel-model ODE system (with a readable minimalistic SciPy+pint solution) Mar 16, 2024
@slayoo
Copy link
Member

slayoo commented Mar 18, 2024

closing and reopening to trigger rebuild against current main (where the updated devops_tests will detect the rendering problem with notebooks caused by buggy PyCharm version)

@slayoo slayoo closed this Mar 18, 2024
@slayoo slayoo reopened this Mar 18, 2024
@slayoo
Copy link
Member

slayoo commented Mar 18, 2024

@bhiogade, thanks! Here are some comments:

  • there seem to be a clash between saturated_vaporpressure and saturated_vapor_pressure
  • let's remove all unused variables (pylint will help)
  • total_multiplicity is the same as TOTAL_AEROSOL_NUMBER - worth removing for now for clarity?
  • it would be beneficial to separate physical constants (e.g., g, R, etc) from model parameters (e.g., updraft)

@slayoo
Copy link
Member

slayoo commented Mar 18, 2024

BTW

  • it seems that we do not really need to import numpy here - worth removing to keep it minimalistic as per the original idea - it should also help to make the code more readable (no more np.asarray, etc); for defining output steps, we could replace np.linspace(...) with nt = 40; dt_out = 5 * si.s; t=[(i*dt_out).to(si.s).magnitude for i in range(0, nt)] and then provide GUI sliders for nt and dt_out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants