Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instr-grpc): update semconv to 1.27 #5002

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JamieDanielson
Copy link
Member

@JamieDanielson JamieDanielson commented Sep 18, 2024

Which problem is this PR solving?

Short description of the changes

  • use new ATTR_* for stable http/net attributes
  • start adding logic for opt-in options

Question: Should we be using ATTR_* from incubating, or keep using SEMATTRS_*? Asked on http server PR

TODO

  • OTEL_SEMCONV_STABILITY_OPT_IN
  • ATTR_NET_PEER_NAME => ATTR_SERVER_ADDRESS || ATTR_CLIENT_ADDRESS from stable
  • ATTR_NET_PEER_PORT => ATTR_SERVER_PORT || ATTR_CLIENT_PORT from stable

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • unit tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant