Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the filepaths in unit test #222

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Correct the filepaths in unit test #222

merged 3 commits into from
Aug 21, 2024

Conversation

niketagrawal
Copy link
Collaborator

@niketagrawal niketagrawal commented Aug 19, 2024 •
edited
Loading

@niketagrawal niketagrawal requested review from Sierd and removed request for Sierd August 19, 2024 13:15
@niketagrawal niketagrawal marked this pull request as draft August 19, 2024 13:17
@niketagrawal niketagrawal marked this pull request as ready for review August 19, 2024 13:26
@niketagrawal niketagrawal self-assigned this Aug 19, 2024
@niketagrawal niketagrawal removed the request for review from Sierd August 19, 2024 13:27
Sierd
Sierd reviewed Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@Sierd Sierd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks Niket.

@Sierd Sierd merged commit 6afe8ee into main Aug 21, 2024
0 of 3 checks passed
@Sierd Sierd deleted the 221-fix-filepath-in-unittest branch August 21, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sierd Sierd Sierd approved these changes

Assignees

@niketagrawal niketagrawal

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect file paths causing test_parse_callback_from_module() to fail
2 participants
@niketagrawal @Sierd