Include options to EO-RIVER tools for requesting data-url only and to not only take the largest polygon #40
Conversation
hydroengine_service/main.py
Outdated
| @@ -800,14 +802,16 @@ def get_water_network(): | |||
|
|
|||
| j = request.json | |||
|
|
|||
| use_url = j['use_url'] | |||
There was a problem hiding this comment.
Maybe make it more explicit, for example:
"output_type": ['geojson', 'geojson_url']
There was a problem hiding this comment.
My implementation is already applied in other places of the code, and thus makes things more uniform. I agree that your approach is more nice, but it lacks consistency.
There was a problem hiding this comment.
Consistency with what? This approach is more consistent since you won't need to add another parameter if we add export tot GDrive, storage buckets, etc.
There was a problem hiding this comment.
Consistency with the current code: https://github.com/openearth/hydro-engine-service/blob/master/hydroengine_service/main.py#L580
There was a problem hiding this comment.
Ah, ok, it was already like that :)
|
The build is failing, should be fixed before merge |
Are you able to run the CI? I do not have the private_key_file. |
…de this argument and this allows for a more stable approach
|
I managed to get the private_key working, both local and on my own TRAVIS (see below). Thanks for the help! This made me do small adjustments. However, still it's failing because I cannot setup the private_key at the openearth-TRAVIS (no permission I suppose). Here is my prove that build is succesful: https://travis-ci.com/github/jurjendejong/hydro-engine-service/builds/178883887 Edit: I realise there is no need to hurry as I can also now use the local build. Le's get back to this after your holiday. |
|
Can we update this to the latest structure and merge it? |
The changes are untested as I do not know how I could...