Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some features for params file and making non-hydrostatic model. #28

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

WaveHello
Copy link

I'm using the package to generate some non-hydrostatic models so I added the capability to generate the boun_U.bcf file and the related flags in the params file. During the process of debugging my xBeach model it was hard to compare the params file to the XBlog file due to the formatting differences. To help with that I added some additional functions to help format the params file.

@MarliesA MarliesA self-requested a review July 17, 2024 15:30
@MarliesA MarliesA self-assigned this Jul 17, 2024
Copy link
Collaborator

@MarliesA MarliesA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi WaveHello,

Thanks for these contributions! Particularly the improved readability of the params is great.

I have one request: can you remove the commit of the doc_utilities/pycache? Perhaps it is most convenient to change this in your fork and then ask for a new pull-request.

with regards,
Marlies

@WaveHello
Copy link
Author

Hello Marlies,

Thanks for the feedback! I've removed the pycache from the latest commit and have added .pyc files to the gitignore file. If you want the pycache file completely removed from the git history I can do that to, it'll just take a little longer. Also please let me know if I need to make any other changes.

On a complete change of topics, I've been trying to recreate the xbeach solitary wave example in Smit (2008) Link and have been having some trouble. I've looked around for a xbeach discussion forum and haven't been able to find one. I was wondering if you could point me in the right direction. I know this isn't tied to the repo, so sorry for asking here, but I figured I'd shoot my shot anyway.

Thanks!

@WaveHello
Copy link
Author

Hello Marlies,

I'm following up integrating this pull request. Is there something else you'd like me to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants