Fix bug that can prevent fast-polling clients from ever getting data again #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fixje Would be great to get your eyes on this! |
|
@MatthewMeacham, I'd rather someone else to do the review, I don't know java very well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the Java client where a fast-polling client (i.e. more frequently than the 4900ms/9900ms rate-limiting for anon/authed, respectively) could result in never making a call to the OpenSky API again.
The issue here was that we would always update
lastRequestTimeeven if the caller wasn't actually able to issue a call, resulting in never being able to issue a call after the first time.