Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Adding tasks to test liquidity bot #500

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

daryakaviani
Copy link
Contributor

@daryakaviani daryakaviani commented May 31, 2022

Task: Adding tasks to test liquidity bot

Description

Right now, the liquidity bot seems to miss some liquidatable vaults. This task sequence is designed to see whether the bot liquidates an underwater vault:

  • Run liquidation bot on ropsten
  • Run openShortVault task to create a short position with a 150% collateralization ratio
  • Run (preexisting) wethWhacker task to tank the ETH price and take the newly created vault underwater
  • Run checkVaultStatus task to verify that the vault is no longer safe
  • Check whether bot successfully liquidates

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document update

How Has This Been Tested

Please describe how to test to verify the changes. Provide instructions so we can reproduce.

Test with the task sequence above

FE Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Added video recordings if it is a UI change

User Facing Checklist

  • I fully understand the user problem this PR is solving
  • I know who the target user is for this PR and have a deep understanding of that user
  • I have tried this flow thinking from the pov of the target user for this PR
  • I (or working w someone on team) have scheduled a user test for this PR (if it is a large change)

@vercel
Copy link

vercel bot commented May 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
continuouscall ✅ Ready (Inspect) Visit Preview Jun 1, 2022 at 0:22AM (UTC)

@daryakaviani daryakaviani self-assigned this May 31, 2022
@daryakaviani daryakaviani changed the title Adding Tasks to Test Liquidity Bot Adding tasks to test liquidity bot May 31, 2022
@haythemsellami haythemsellami changed the title Adding tasks to test liquidity bot [WIP]Adding tasks to test liquidity bot May 31, 2022
@KMKoushik
Copy link
Contributor

@haythem96 Do we need this still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants