Start indexing at the appropriate block #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using --index-sats or --index-addresses, we need to index all blocks, but --index-inscriptions only needs blocks starting from 767430, and --index-runes can start at 840000. The existing code for this is tricky and also wrong -- it incorrectly skips early blocks when using --index-addresses but not --index-sats, and it unnecessarily processes blocks from 767430 to 840000 when using --index-runes but not --index-inscriptions.
Replace the old code with a single, correct calculation of which block to start at. This speeds up building a runes-only index by about 4x.