Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate commented messages #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ahoarau
Copy link
Contributor

@ahoarau ahoarau commented Jan 30, 2020

Better than removing the messages.

@meyerj
Copy link
Member

meyerj commented Jan 30, 2020

The problem is that they won't work at the moment without making some of the private data accessible for ROS serialization and deserialization.

I have a working version that re-adds support for all types in another, internal set of repos, but this also requires some non-ABI-compatible patches to KDL. At the very minimal we would have to add some friend declarations, like it is done with boost::serialization::access.

@ahoarau
Copy link
Contributor Author

ahoarau commented Feb 1, 2020

Then I'm in favor of putting the commented messages in another folder, some of the message generators out there are listing the '*.msg' in the 'msg/' dirs, even the commented ones.

@meyerj
Copy link
Member

meyerj commented Feb 3, 2020

Then I'm in favor of putting the commented messages in another folder, some of the message generators out there are listing the '*.msg' in the 'msg/' dirs, even the commented ones.

Indeed, that could be done. Or just delete the msg files and the commented code completely.
Would you mind updating the PR accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants