ci: remove workspace and fix to test lib with MSRV 1.57.0 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
force-pushed
the
ci/fix_msrv
branch
3 times, most recently
from
99dd1e1
to
2e6b81f
Compare
notmandatory
force-pushed
the
ci/fix_msrv
branch
from
2e6b81f
to
5ab821a
Compare
DanGould
reviewed
Aug 5, 2023
payjoin/Cargo.lock
Outdated
| @@ -0,0 +1,1258 @@ | |||
| # This file is automatically @generated by Cargo. | |||
There was a problem hiding this comment.
Since this is just for the library I think it can safely be .gitignore-d. Is this necessary this is for expressing MSRV?
There was a problem hiding this comment.
I agree we should remove and .gitignore Cargo.lock for the lib. That's another advantage of removing the workspace is you can keep a Cargo.lock for the payjoin-cli bin project if you want.
DanGould
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way I'm able to pin the
rust-payjoindependencies to be able to build/test the lib with MSRV 1.57.0 was to remove the workspace. I also changed the github actions workflow to useruninstead of theactions-rs/cargo@v1plugin since it doesn't support sub-directories.