#1717 backlinks: don't detect checkboxes as part of links

Signed-off-by: Patrizio Bekerle <[email protected]>
pbek · Sep 4, 2024 · d518efe · d518efe
1 parent c9ecc3a
commit d518efe
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # QOwnNotes Changelog
 
+## 24.9.2
+- The **backlink widget** link detection was improved
+  (for [#1717](https://github.com/pbek/QOwnNotes/issues/1717))
+  - In checkbox lists the checkboxes will now not be detected as part of the links
+
 ## 24.9.1
 - The **backlink widget** in the navigation panel now also shows the links in the notes
   to the current note (for [#1717](https://github.com/pbek/QOwnNotes/issues/1717))

diff --git a/src/entities/note.cpp b/src/entities/note.cpp
@@ -3185,7 +3185,7 @@ QHash<Note, QList<BacklinkHit>> Note::findReverseLinkNotes() {
         // search legacy links
         addTextToBacklinkNoteHashIfFound(note, QStringLiteral("<") + noteUrl + QStringLiteral(">"));
         addTextToBacklinkNoteHashIfFound(
-            note, QRegularExpression(QStringLiteral(R"(\[(.+)\]\()") +
+            note, QRegularExpression(QStringLiteral(R"(\[([^\[\]]+?)\]\()") +
                                      QRegularExpression::escape(noteUrl) + QStringLiteral(R"(\))")));
 
         // search for legacy links ending with "@"
@@ -3206,11 +3206,11 @@ QHash<Note, QList<BacklinkHit>> Note::findReverseLinkNotes() {
         addTextToBacklinkNoteHashIfFound(
             note, QStringLiteral("<") + relativeFilePath + QStringLiteral(">"));
         addTextToBacklinkNoteHashIfFound(
-            note, QRegularExpression(QStringLiteral(R"(\[(.+)\]\()") +
+            note, QRegularExpression(QStringLiteral(R"(\[([^\[\]]+?)\]\()") +
                                      QRegularExpression::escape(relativeFilePath) +
-                                     QStringLiteral(R"(\))")));
+                                     QStringLiteral(R"(\))"), QRegularExpression::MultilineOption));
         addTextToBacklinkNoteHashIfFound(
-            note, QRegularExpression(QStringLiteral(R"(\[(.+)\]\()") +
+            note, QRegularExpression(QStringLiteral(R"(\[([^\[\]]+?)\]\()") +
                                      QRegularExpression::escape(relativeFilePath) +
                                      QStringLiteral(R"(#.+\))")));
     }