feat: events for ibc transfers #4874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
force-pushed
the
transfer-events
branch
from
17ce98c
to
189bf3c
Compare
This adds events for outbound, inbound, and refunds. This also adds sufficient metadata to uniquely identify which transfer is being refunded, and where transfers are going.
cronokirby
force-pushed
the
transfer-events
branch
from
189bf3c
to
73ed720
Compare
|
Note: there is a bug in this and the related PR for refunds, where the receiver address for refunds is populated incorrectly. |
cronokirby
force-pushed
the
transfer-events
branch
from
73ed720
to
d682205
Compare
Fixed on latest push, confirm? |
|
Confirmed with @cronokirby out of band that this patch is good to go. |
|
Refs #4871 |
conorsch
approved these changes
Oct 2, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This adds specific events related to fungible token transfers, recording them as they happen in the shielded pool.
First of all, this is a much more legible and readily consumable event around actual IBC events we care about, which is reason enough to have this, imo, but also, there's currently a flaw in the whole event system in that we don't have access, through events only, to the actual acknowledgement data for a packet.
In particular, we can't tell using the raw ibc events if a packet was acked successfully, finalizing a transfer, or unsuccessfully, causing the transfer to be refunded.
Knowing which of the two matters a lot, and will cause queries like "how much of this asset has been locked in the shielded pool" to not return the right result by quite a bit.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: