Always reset exit code

phntmxyz · Jun 19, 2024 · cfffb36 · cfffb36
1 parent 8a96ea1
commit cfffb36
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 0 deletions.
diff --git a/sidekick_core/test/analyzer_command_test.dart b/sidekick_core/test/analyzer_command_test.dart
@@ -3,6 +3,7 @@ import 'package:sidekick_test/sidekick_test.dart';
 import 'package:test/test.dart';
 
 void main() {
+  tearDown(() => exitCode = 0);
   test('analyze command sets exitCode 1 when command fails', () async {
     await insideFakeProjectWithSidekick((dir) async {
       dir.file('dash_sidekick.dart').writeAsStringSync('''

diff --git a/sidekick_core/test/bash_command_test.dart b/sidekick_core/test/bash_command_test.dart
@@ -4,6 +4,7 @@ import 'package:sidekick_test/sidekick_test.dart';
 import 'package:test/test.dart';
 
 void main() {
+  tearDown(() => exitCode = 0);
   test('bash command receives arguments', () async {
     await insideFakeProjectWithSidekick((dir) async {
       final runner = initializeSidekick(

diff --git a/sidekick_core/test/dart_command_test.dart b/sidekick_core/test/dart_command_test.dart
@@ -3,6 +3,7 @@ import 'package:sidekick_test/sidekick_test.dart';
 import 'package:test/test.dart';
 
 void main() {
+  tearDown(() => exitCode = 0);
   test('dart command works when dartSdkPath is set', () async {
     await insideFakeProjectWithSidekick((dir) async {
       final runner = initializeSidekick(

diff --git a/sidekick_core/test/deps_command_test.dart b/sidekick_core/test/deps_command_test.dart
@@ -5,6 +5,8 @@ import 'package:sidekick_test/sidekick_test.dart';
 import 'package:test/test.dart';
 
 void main() {
+  tearDown(() => exitCode = 0);
+
   void setUpPackages(Directory tempDir) {
     final packages = [
       'foo/a',

diff --git a/sidekick_core/test/flutter_command_test.dart b/sidekick_core/test/flutter_command_test.dart
@@ -3,6 +3,7 @@ import 'package:sidekick_test/sidekick_test.dart';
 import 'package:test/test.dart';
 
 void main() {
+  tearDown(() => exitCode = 0);
   test('flutter command works when flutterSdkPath is set', () async {
     await insideFakeProjectWithSidekick((dir) async {
       final runner = initializeSidekick(

diff --git a/sidekick_core/test/format_command_test.dart b/sidekick_core/test/format_command_test.dart
@@ -18,6 +18,8 @@ void main() {
     mainFile.writeAsStringSync(mainContent);
   }
 
+  tearDown(() => exitCode = 0);
+
   group('getLineLength', () {
     late File pubspecYamlFile;
     late DartPackage package;