Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SSL for all server #441

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Conversation

TasdidurRahman
Copy link
Contributor

@TasdidurRahman TasdidurRahman commented Aug 1, 2024

enable ssl connection with upstream. no ca used.
variable introduced:
PMA_SSL for single upstream
PMA_SSLS for multiple upstream
docker run ... -e PMA_HOSTS="mysql-notls,mysql-tls" -e PMA_SSLS="0,1" ...

Signed-off-by: TasdidurRahman <[email protected]>
@TasdidurRahman
Copy link
Contributor Author

wrong upstream

@williamdes
Copy link
Member

wrong upstream

If you want you can contribute adding support for SSL via ENVs
See: https://github.com/phpmyadmin/docker/issues?q=is%3Aissue+is%3Aopen+SSL

@williamdes williamdes self-assigned this Aug 1, 2024
Signed-off-by: TasdidurRahman <[email protected]>
@TasdidurRahman
Copy link
Contributor Author

hi @williamdes, can you review this?

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update https://github.com/phpmyadmin/docker/blob/master/config.inc.php
And run ./update.sh

Can you also add documentation on the README ?
It is unclear how to use this

PMA_SSLS="0,1" is maybe not very user friendly

Signed-off-by: TasdidurRahman <[email protected]>
@TasdidurRahman
Copy link
Contributor Author

TasdidurRahman commented Aug 19, 2024

PMA_SSLS="0,1" is maybe not very user friendly

imo this is better to keep it simple as we are not using CA rn. still we are open for suggestion!
@williamdes

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I did not see that other ENVs have the same logic
Please add documentation to the README and say the variable works in the same way that PMA_PORTS works

Signed-off-by: TasdidurRahman <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: TasdidurRahman <[email protected]>
@williamdes williamdes merged commit 8831312 into phpmyadmin:master Aug 20, 2024
39 checks passed
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@williamdes
Copy link
Member

williamdes commented Aug 20, 2024

I sent your changes to the official registry: docker-library/official-images#17398

TODO myself:

  • Update the PMA 5.2 & 6.0 docs for Docker
  • Update the official Docker docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants