Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: use ordered map to maintain the queue #56443

Closed

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: ref #55906

Problem Summary:

What changed and how does it work?

This PR is based on #56437

Using an ordered map to store all jobs in memory would simplify how we handle auto-analyze ratio and table lock changes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

fix: do not maintain time window in the queue

refactor: make lint happy

docs: add FIXME

refactor: rename to rebuildWithoutLock

fix

docs: add more comments

fix

fix

fix

fix

fix

fix

fix

fix
fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix
fix

fix

fix

fix

fix

fix

fix

fix
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner labels Oct 3, 2024
Copy link

ti-chi-bot bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rustin170506, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 3, 2024
@Rustin170506 Rustin170506 force-pushed the rustin-patch-sorted-array branch 2 times, most recently from 327ac9e to abd3381 Compare October 3, 2024 11:16
Copy link

tiprow bot commented Oct 3, 2024

@Rustin170506: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 2381166 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 49.18519% with 343 lines in your changes missing coverage. Please review.

Project coverage is 74.7276%. Comparing base (74034d4) to head (2381166).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56443        +/-   ##
================================================
+ Coverage   73.3645%   74.7276%   +1.3630%     
================================================
  Files          1624       1648        +24     
  Lines        448069     456590      +8521     
================================================
+ Hits         328724     341199     +12475     
+ Misses        99207      94191      -5016     
- Partials      20138      21200      +1062     
Flag Coverage Δ
integration 30.7596% <1.6296%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.2859% <ø> (+6.7729%) ⬆️

Copy link

ti-chi-bot bot commented Oct 3, 2024

@Rustin170506: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 2381166 link true /test check-dev
idc-jenkins-ci-tidb/unit-test 2381166 link true /test unit-test
pull-lightning-integration-test 2381166 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant