-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: use ordered map to maintain the queue #56443
statistics: use ordered map to maintain the queue #56443
Conversation
fix: do not maintain time window in the queue refactor: make lint happy docs: add FIXME refactor: rename to rebuildWithoutLock fix docs: add more comments fix fix fix fix fix fix fix fix
fix fix
fix fix fix fix fix fix fix fix fix fix fix fix fix fix fix
fix fix fix fix fix fix fix fix
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
327ac9e
to
abd3381
Compare
fix fix fix fix fix fix fix
abd3381
to
2381166
Compare
@Rustin170506: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56443 +/- ##
================================================
+ Coverage 73.3645% 74.7276% +1.3630%
================================================
Files 1624 1648 +24
Lines 448069 456590 +8521
================================================
+ Hits 328724 341199 +12475
+ Misses 99207 94191 -5016
- Partials 20138 21200 +1062
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@Rustin170506: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #55906
Problem Summary:
What changed and how does it work?
This PR is based on #56437
Using an ordered map to store all jobs in memory would simplify how we handle auto-analyze ratio and table lock changes.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.